Handle STS Credentials region #8605

ben-taussig-solo · 2023-08-22T15:14:39Z

Description

Along with the changes in Handle STS Credentials Region envoy-gloo#267, fixes a bug where assuming a secondary role using an EKS ServiceAccount would fail when the service account was not in us-east-1 in some instances

solo-changelog-bot · 2023-08-22T15:23:52Z

Issues linked to changelog:
#8578

github-actions · 2023-08-22T16:05:14Z

Visit the preview URL for this PR (updated for commit 776da72):

https://gloo-edge--pr8605-handle-sts-credentia-zwzo154e.web.app

_{(expires Wed, 20 Sep 2023 19:10:25 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 77c2b86e287749579b7ff9cadb81e099042ef677}

projects/gloo/api/external/envoy/extensions/aws/filter.proto

…oo into handle-sts-credentials-region

test/e2e/aws_test.go

ben-taussig-solo · 2023-09-13T18:59:12Z

/kick failure in consul plugin tests, presumably a flake: https://storage.googleapis.com/solo-public-build-logs/logs.html?buildid=aaa1a4e9-cf13-457f-8478-17ec2c9dd0b1

nfuden

Looks good!

* update API * explicitly set region in serviceAccountCredentials * add changelog entry * relocate changelog entry to proper release * update test fixture in helm tests * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * add STS tests * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * make region not required * add e2e tests against default region * correct typo in aws e2e tests * bump envoy-gloo version * remove unnecessary tests from AWS e2e test --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot>

jenshu · 2023-09-13T21:48:21Z

Makefile

-# Regex copied from: https://github.com/solo-io/go-utils/blob/16d4d94e4e5f182ca8c10c5823df303087879dea/versionutils/version.go#L338
-tag_regex := v[0-9]+[.][0-9]+[.][0-9]+(-[a-z]+)*(-[a-z]+[0-9]*)?$
+tag_regex := ^v([0-9]{1,}\.){2}[0-9]{1,}$


looks like you accidentally reverted this change from #8653

* Handle STS Credentials region (#8605) * update API * explicitly set region in serviceAccountCredentials * add changelog entry * relocate changelog entry to proper release * update test fixture in helm tests * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * add STS tests * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * make region not required * add e2e tests against default region * correct typo in aws e2e tests * bump envoy-gloo version * remove unnecessary tests from AWS e2e test --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot> * codegen * codegen --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>

* update API * explicitly set region in serviceAccountCredentials * add changelog entry * relocate changelog entry to proper release * update test fixture in helm tests * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * add STS tests * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * make region not required * add e2e tests against default region * correct typo in aws e2e tests * bump envoy-gloo version * remove unnecessary tests from AWS e2e test --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>

* Handle STS Credentials region (#8605) * update API * explicitly set region in serviceAccountCredentials * add changelog entry * relocate changelog entry to proper release * update test fixture in helm tests * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * add STS tests * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * make region not required * add e2e tests against default region * correct typo in aws e2e tests * bump envoy-gloo version * remove unnecessary tests from AWS e2e test --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot> * trigger build * codegen --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>

ben-taussig-solo added 2 commits August 22, 2023 11:13

update API

8a0961c

explicitly set region in serviceAccountCredentials

5d6e4d1

ben-taussig-solo requested a review from a team as a code owner August 22, 2023 15:14

github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label Aug 22, 2023

ben-taussig-solo added 2 commits August 22, 2023 11:15

add changelog entry

621afc3

relocate changelog entry to proper release

c32379a

update test fixture in helm tests

8d632a5

soloio-bulldozer bot and others added 14 commits August 22, 2023 17:56

Merge refs/heads/main into handle-sts-credentials-region

cb65a43

Merge refs/heads/main into handle-sts-credentials-region

991d269

Adding changelog file to new location

89db236

Deleting changelog file from old location

49b3f1b

Merge refs/heads/main into handle-sts-credentials-region

e42752b

Merge refs/heads/main into handle-sts-credentials-region

96cc759

Merge refs/heads/main into handle-sts-credentials-region

1b685aa

Merge refs/heads/main into handle-sts-credentials-region

b66da6c

Merge refs/heads/main into handle-sts-credentials-region

de28913

Merge refs/heads/main into handle-sts-credentials-region

266ab65

Adding changelog file to new location

72248c4

Deleting changelog file from old location

8e77463

Merge refs/heads/main into handle-sts-credentials-region

856e951

Merge refs/heads/main into handle-sts-credentials-region

e7d58ba

ben-taussig-solo mentioned this pull request Sep 5, 2023

[DNM] Evaluate AWS STS e2e tests #8644

Closed

Merge refs/heads/main into handle-sts-credentials-region

d82f5f8

ben-taussig-solo commented Sep 6, 2023

View reviewed changes

projects/gloo/api/external/envoy/extensions/aws/filter.proto Outdated Show resolved Hide resolved

ben-taussig-solo and others added 4 commits September 6, 2023 09:49

add STS tests

646c7fc

Merge refs/heads/main into handle-sts-credentials-region

c3a746e

Adding changelog file to new location

0c76c8f

Deleting changelog file from old location

9ccd10d

soloio-bulldozer bot and others added 6 commits September 8, 2023 16:52

Merge refs/heads/main into handle-sts-credentials-region

1b08606

Merge refs/heads/main into handle-sts-credentials-region

4d7d42c

Merge refs/heads/main into handle-sts-credentials-region

8e7f1f2

Merge refs/heads/main into handle-sts-credentials-region

7679dc7

Adding changelog file to new location

5a54772

Deleting changelog file from old location

ce9e7ce

ben-taussig-solo mentioned this pull request Sep 11, 2023

Handle STS Credentials Region solo-io/envoy-gloo#267

Merged

ben-taussig-solo added 5 commits September 12, 2023 09:17

make region not required

f52cad4

add e2e tests against default region

b3ea57b

Merge branch 'handle-sts-credentials-region' of github.com:solo-io/gl…

7afd3bb

…oo into handle-sts-credentials-region

correct typo in aws e2e tests

e853181

bump envoy-gloo version

2544b70

nfuden reviewed Sep 13, 2023

View reviewed changes

test/e2e/aws_test.go Outdated Show resolved Hide resolved

remove unnecessary tests from AWS e2e test

776da72

ashishb-solo approved these changes Sep 13, 2023

View reviewed changes

nfuden approved these changes Sep 13, 2023

View reviewed changes

soloio-bulldozer bot merged commit b5f2f40 into main Sep 13, 2023
14 checks passed

soloio-bulldozer bot deleted the handle-sts-credentials-region branch September 13, 2023 19:36

ben-taussig-solo mentioned this pull request Sep 13, 2023

[v1.15.x] Backport Handle STS Credentials region (#8605) #8680

Merged

ben-taussig-solo mentioned this pull request Sep 13, 2023

[v1.14.x] Backport Handle STS Credentials region (#8605) #8681

Merged

ben-taussig-solo mentioned this pull request Sep 13, 2023

[v1.13.x] Backport Handle STS Credentials region (#8605) #8682

Merged

jenshu reviewed Sep 13, 2023

View reviewed changes

ben-taussig-solo mentioned this pull request Sep 14, 2023

Restore tag_regex in Makefile #8683

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle STS Credentials region #8605

Handle STS Credentials region #8605

ben-taussig-solo commented Aug 22, 2023 •

edited by nfuden

Loading

solo-changelog-bot bot commented Aug 22, 2023

github-actions bot commented Aug 22, 2023 •

edited

Loading

ben-taussig-solo commented Sep 13, 2023

nfuden left a comment

jenshu Sep 13, 2023

Handle STS Credentials region #8605

Handle STS Credentials region #8605

Conversation

ben-taussig-solo commented Aug 22, 2023 • edited by nfuden Loading

Description

solo-changelog-bot bot commented Aug 22, 2023

github-actions bot commented Aug 22, 2023 • edited Loading

ben-taussig-solo commented Sep 13, 2023

nfuden left a comment

Choose a reason for hiding this comment

jenshu Sep 13, 2023

Choose a reason for hiding this comment

ben-taussig-solo commented Aug 22, 2023 •

edited by nfuden

Loading

github-actions bot commented Aug 22, 2023 •

edited

Loading