Fix solo-apis action and small addition to rlc translation fix. #8581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
github-actions
bot
added
the
keep pr updated
jenshu
approved these changes
Aug 15, 2023
sam-heilbron
approved these changes
Aug 15, 2023
|
Visit the preview URL for this PR (updated for commit 863d5f0): https://gloo-edge--pr8581-solo-apis-action-4p0vrvnw.web.app (expires Tue, 22 Aug 2023 15:11:24 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
elcasteel
added a commit
that referenced
this pull request
Aug 15, 2023
elcasteel
added a commit
that referenced
this pull request
Aug 15, 2023
…PR action (#8582) * Reject ratelimit configs that are missing required values. (#8575) * plugin updates and test * gofmt * review comments, do not append invalid action to returned list * link to envoy docs in changelog * Fix solo-apis action and small addition to rlc translation fix. (#8581) * update changelog
sheidkamp
pushed a commit
that referenced
this pull request
Aug 22, 2023
…PR action (#8582) * Reject ratelimit configs that are missing required values. (#8575) * plugin updates and test * gofmt * review comments, do not append invalid action to returned list * link to envoy docs in changelog * Fix solo-apis action and small addition to rlc translation fix. (#8581) * update changelog
sheidkamp
pushed a commit
that referenced
this pull request
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the correct path for the composite actions when actions have a different working directory.
Add a default case when translating ratelimit actions. In addition to missing fields, it's also possible to define config for an action that can't be cast. Without a default case, we give Envoy an empty action that makes it unhappy.
Context
Failed solo-apis run: https://github.com/solo-io/gloo/actions/runs/5860985506