Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Validate GHA Cache Miss #8546

Closed
wants to merge 1 commit into from

Conversation

sam-heilbron
Copy link
Contributor

@sam-heilbron sam-heilbron commented Aug 7, 2023

Description

Validate that a change with some go.mod updates, results in a github action cache miss

This is not meant to merge, just demonstrate behavior, and then be closed

Context

In #8545 we proved that cache hits work. This PR demonstrates that cache misses occur as well.

Screen Shot 2023-08-07 at 12 26 21 PM

Testing steps

  • Confirm that codegen step experienced a cache miss
  • Confirm that GHA 1.14.x cache is not updated
  • Confirm that a new cache entry exists for this PR

Notes for reviewers

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label Aug 7, 2023
@sam-heilbron sam-heilbron deleted the gha-cache-14/validate-cache-miss branch August 7, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant