Handle missing TCP upstreams as warnings (#8461) #8469
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle missing TCP upstreams as warnings
Move changelog to new location
Fix a broken test
Apply suggestions from code review
Fix error in changelog
Address nil safety issue on TcpHostError
Fix nil safety check
Address a few review comments
Update projects/gloo/api/grpc/validation/gloo_validation.proto
Populate ErrorLevel for TcpHostWarning
Mark InvalidDestinationError as deprecated
Add some stricter error checking
Move duplicated code into a reusable function
Codegen
Fix an error from refactor
Use the ErrorWithKnownLevel interface to switch on error report types
Handle the case where tcp host num is not provided
Provide a separate Context object to carry additional information
Earlier commits simply added more fields to the ErrorWithKnownLevel interface to aid in providing the necessary information required to report the error. This commit is an attempt to break that out into a separate object so additional fields do not need to be added every time more contextual information is needed to correctly report the error
Add docstrings on exported types
Adding changelog file to new location
Deleting changelog file from old location
Adding changelog file to new location
Deleting changelog file from old location
Clean up hard-coded warning type
Previously, we were just using InvalidDestinationWarning for all warning types
Description
Please include a summary of the changes.
This bug fixes ... \ This new feature can be used to ...
Context
Users ran into this bug doing ... \ Users needed this feature to ...
Checklist:
make -B install-go-tools generated-code
to ensure there will be no code diffBOT NOTES:
resolves https://github.com/solo-io/solo-projects/issues/5163