Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport docs to v1.13.x #8449

Merged
merged 6 commits into from
Jul 7, 2023
Merged

Backport docs to v1.13.x #8449

merged 6 commits into from
Jul 7, 2023

Conversation

artberger
Copy link
Contributor

Description

Backport docs to v1.13.x, follow up to #8443, #8447

Checklist:

  • I included a concise, user-facing changelog (for details, see https://github.com/solo-io/go-utils/tree/main/changelogutils) which references the issue that is resolved.
  • If I updated APIs (our protos) or helm values, I ran make -B install-go-tools generated-code to ensure there will be no code diff
  • I followed guidelines laid out in the Gloo Edge contribution guide
  • I opened a draft PR or added the work in progress label if my PR is not ready for review
  • N/A I have performed a self-review of my own code
  • N/A I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • N/A I have added tests that prove my fix is effective or that my feature works

artberger and others added 5 commits July 7, 2023 14:14
@artberger @Rachael-Graham
Docs for inheritance (#8443)
2878e47 
* Docs for inheritance

Adding to the concepts page and linking to existing docs on transformation and auth config as examples

* changelog

* grammar

* add more detailed header example

* Apply suggestions from code review

Co-authored-by: Rachael Graham <rachael.graham@solo.io>

---------

Co-authored-by: Rachael Graham <rachael.graham@solo.io>
@artberger
changelog
f511008
@artberger
rm 1.10 content
63b98eb
@artberger
version bump
fda7efc
@artberger
fix video link, see Slack: https://solo-io-corp.slack.com/archives/CH…
e413192 
…JV572TG/p1688750427833549
@artberger artberger requested a review from a team as a code owner July 7, 2023 18:23
@artberger artberger self-assigned this Jul 7, 2023
@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label Jul 7, 2023
Rachael-Graham
Rachael-Graham previously approved these changes Jul 7, 2023
View reviewed changes
@artberger
Copy link
Contributor Author

/kick

@soloio-bulldozer soloio-bulldozer bot merged commit d9af6b4 into v1.13.x Jul 7, 2023
12 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the v1.13.x-docs branch July 7, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nadine2016 Nadine2016 Nadine2016 approved these changes

@Rachael-Graham Rachael-Graham Rachael-Graham approved these changes

Assignees

@artberger artberger

Labels
keep pr updated signals bulldozer to keep pr up to date with base branch Type: Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artberger @Nadine2016 @Rachael-Graham