8405 aggregate listener crash v1.14.x #8433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Attempt to fix issue Doesn't seem to crash right now, but this is a partial commit so I hope I didn't miss anything * Add changelog * Adding changelog file to new location * Deleting changelog file from old location * Commit test to show bugfix works * Move the test to a better location * Add GetProxyError test for aggregate listener * Add tests for reporting errors in tcp listeners in aggregate filter chains * Update projects/gloo/pkg/utils/validation/proxy_validation_test.go Co-authored-by: Jenny Shu <28537278+jenshu@users.noreply.github.com> * Improve name on helper function * Add tcp tests for hybrid listeners * Add http reports for aggregate listener * Rename test * Clean up test, make it more consistent --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot> Co-authored-by: Jenny Shu <28537278+jenshu@users.noreply.github.com>
…tener-crash-v1.14.x
|
Issues linked to changelog: |
jenshu
approved these changes
Jun 30, 2023
kdorosh
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport fix for crash in aggregate listener filter chains to v1.14.x (#8407)
Context
Backport of bugfix
Checklist:
make -B install-go-tools generated-codeto ensure there will be no code diffBOT NOTES:
resolves #8405