ci(deploy-to-kind-cluster): added default env vars #5473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunnar-solo
force-pushed
the
ci-script-tweaks
branch
2 times, most recently
from
fad3d67
to
88fe95f
Compare
\# Description * classify between `darwin` vs. `linux` systems when running `ci/deploy-to-kind-cluster.sh` * default `KUBE2E_TESTS` to `eds`, rather than nothing This commit can be used to run `ci/deploy-to-kind-cluster.sh` on a mac off of a fresh clone with no configuration \# Context One of the more common use-cases for `deploy-to-kind-cluster` is in local development. _Currently_, when running the script, some tweaks are needed to have it _succeed_ on a Mac. This is a bit painful, and is time that not every person on a Mac should need to figure out in order to test locally.
gunnar-solo
force-pushed
the
ci-script-tweaks
branch
from
88fe95f
to
85b9197
Compare
elcasteel
approved these changes
Oct 14, 2021
ben-taussig-solo
pushed a commit
that referenced
this pull request
Oct 14, 2021
* ci(deploy-to-kind-cluster): added default env vars \# Description * classify between `darwin` vs. `linux` systems when running `ci/deploy-to-kind-cluster.sh` * default `KUBE2E_TESTS` to `eds`, rather than nothing This commit can be used to run `ci/deploy-to-kind-cluster.sh` on a mac off of a fresh clone with no configuration \# Context One of the more common use-cases for `deploy-to-kind-cluster` is in local development. _Currently_, when running the script, some tweaks are needed to have it _succeed_ on a Mac. This is a bit painful, and is time that not every person on a Mac should need to figure out in order to test locally.
soloio-bulldozer bot
pushed a commit
that referenced
this pull request
Oct 15, 2021
* Create General Service Converter * Update service converter testing * create settings.DiscoveryOptions.GeneralAnnotationUpstreamConfig setting * Use widely supported method of iterating over struct fields * Don't overwrite preexisting config in new converter * Enable general purpose annotation config processor by default * Remove no-longer-used general_annotation_upstream_config setting * Update tests, add new test to confirm that general converter doesn't override Http2 converter * Merge branch 'master' into general-annotation-config-processor * Add changelog entry * Adding changelog file to new location * Deleting changelog file from old location * Ensure that general annotation converter is applied first * Restore check against values set on upstream spec * Merge branch 'general-annotation-config-processor' of github.com:solo-io/gloo into general-annotation-config-processor * trigger build * Revert to init() implementation of serviceConverter intialization * Refactor GeneralServiceConverter.ConvertService for readability, clarifying comments * Create translator.MergeUpstreams util * Testing, clarifying comments around new translator utility * Generalize struct merge logic * Remove unnecessary assertion in mergeStructs * Remove init() approach to creating default service converters, create DefaultServiceConverters method * Move mergeUpstreams util out of gateway, into general annotation converter * Allow general purpose converter to overwrite config from other converters * Define init function in service_converter_interface.go * Swap position of src and dst arguments in mergeUpstreams * Handle output of mergeUpstreams * Don't return upstream from mergeUpstreams * Dont return anything from mergeUpstream * trigger build * Remove isEmptyValue from general_annotation_converter.go * Add user guide for general annotation config * resolve outstanding issues with general annotation converter * ci(deploy-to-kind-cluster): added default env vars (#5473) * ci(deploy-to-kind-cluster): added default env vars \# Description * classify between `darwin` vs. `linux` systems when running `ci/deploy-to-kind-cluster.sh` * default `KUBE2E_TESTS` to `eds`, rather than nothing This commit can be used to run `ci/deploy-to-kind-cluster.sh` on a mac off of a fresh clone with no configuration \# Context One of the more common use-cases for `deploy-to-kind-cluster` is in local development. _Currently_, when running the script, some tweaks are needed to have it _succeed_ on a Mac. This is a bit painful, and is time that not every person on a Mac should need to figure out in order to test locally. * Update docs/content/guides/traffic_management/destination_types/discovered_upstream/discovered-upstream-configuration.md Co-authored-by: Art <artberger@users.noreply.github.com> Update docs/content/guides/traffic_management/destination_types/discovered_upstream/discovered-upstream-configuration.md Co-authored-by: Art <artberger@users.noreply.github.com> Update docs/content/guides/traffic_management/destination_types/discovered_upstream/discovered-upstream-configuration.md Co-authored-by: Art <artberger@users.noreply.github.com> Update docs/content/guides/traffic_management/destination_types/discovered_upstream/discovered-upstream-configuration.md Co-authored-by: Art <artberger@users.noreply.github.com> Update docs/content/guides/traffic_management/destination_types/discovered_upstream/discovered-upstream-configuration.md Co-authored-by: Art <artberger@users.noreply.github.com> Update docs/content/guides/traffic_management/destination_types/discovered_upstream/discovered-upstream-configuration.md Co-authored-by: Art <artberger@users.noreply.github.com> * Merge branch 'master' into general-annotation-config-processor * Resolve failing tests * Merge branch 'general-annotation-config-processor' of github.com:solo-io/gloo into general-annotation-config-processor * Return Spec to function-level scope, clarify fields that cannot be written to * Update general config serviceconverter to no longer require top-level spec field in incoming config * Update docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
darwinvs.linuxsystems when runningci/deploy-to-kind-cluster.shKUBE2E_TESTStoeds, rather than nothingThis commit can be used to run
ci/deploy-to-kind-cluster.shon a mac off of a fresh clone with no configurationContext
One of the more common use-cases for
deploy-to-kind-clusteris in local development. Currently, when running the script, some tweaks are needed to have it succeed on a Mac. This is a bit painful, and is time that not every person on a Mac should need to figure out in order to test locally.Checklist:
make -B install-go-tools generated-codeto ensure there will be no code diff