plugins/aws: Requiretransform may be deprecated but still is in use #10660
+23
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n use (#10606) Co-authored-by: David Jumani <dj.davidjumani1994@gmail.com>
|
Issues linked to changelog: |
davidjumani
changed the title
|
Visit the preview URL for this PR (updated for commit 3475bf2): https://gloo-edge--pr10660-requesttransformorde-69w6mzqv.web.app (expires Tue, 04 Mar 2025 22:57:17 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
nfuden
approved these changes
Feb 26, 2025
andy-fong
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port of #10606
We have this legacy requiretransform functionality.
While deprecated it does have some usage.
In order for route level filter configuration to take affect the filter must also be set in the httpfilter level configuration.
In this case we mistakenly override a bool in at the route level that triggers filterchain level config.
This means that based off the route info having a route with requirestransform may not be sufficient to actually have that route respect the aws configuration