Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Fix wrong path in TestHelmSettings #10172

Merged
merged 3 commits into from
Oct 4, 2024
Merged

tests: Fix wrong path in TestHelmSettings #10172

merged 3 commits into from
Oct 4, 2024
+6 −2

Conversation

davidjumani
Copy link
Contributor

@davidjumani davidjumani commented Oct 4, 2024 •
edited
Loading

Description

Fix wrong path in TestHelmSettings

--- PASS: TestHelmSettings (101.34s)
    --- PASS: TestHelmSettings/HelmSettings (2.66s)
        --- PASS: TestHelmSettings/HelmSettings/TestApplySettingsManifestsFromUnitTests (2.66s)
PASS

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added keep pr updated signals bulldozer to keep pr up to date with base branch work in progress signals bulldozer to keep pr open (don't auto-merge) labels Oct 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 3d938d6):

https://gloo-edge--pr10172-fix-helm-test-path-n3nk26ru.web.app

(expires Fri, 11 Oct 2024 15:24:51 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

@jenshu jenshu removed the work in progress signals bulldozer to keep pr open (don't auto-merge) label Oct 4, 2024
@soloio-bulldozer soloio-bulldozer bot merged commit 70685e8 into main Oct 4, 2024
18 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the fix-helm-test-path branch October 4, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-heilbron sam-heilbron sam-heilbron approved these changes

@jenshu jenshu jenshu approved these changes

Assignees
No one assigned
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidjumani @sam-heilbron @jenshu