-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/kubernetes/e2e/features/deployer: update tests #10158
Conversation
Issues linked to changelog: |
@@ -0,0 +1,91 @@ | |||
package deployer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed this file to remove the deployer
from the name, since that's the package we're in
Visit the preview URL for this PR (updated for commit 1fcfd94): https://gloo-edge--pr10158-sh-improve-e2e-tests-hgl9iu3g.web.app (expires Thu, 10 Oct 2024 18:11:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
|
||
err := s.testInstallation.Actions.Kubectl().ApplyFile(s.ctx, deployerProvisionManifestFile) | ||
s.Require().NoError(err, "can apply manifest") | ||
func (s *testingSuite) TestProvisionDeploymentAndService() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: i assume this is the original test that is being migrated here. The original test also did a simple curl/traffic test, do we want to add that here too, or do you think it's overkill?
i'm ok either way. we probably have enough other tests that do curls
Description
Update the e2e tests that validate the behavior of the deployer
Context
Internal slack context: https://solo-io-corp.slack.com/archives/G01EERAK3KJ/p1727892654195589
Interesting decisions
Testing steps
Locally, I setup a kind cluster, and then ran:
and
and both succeeded
Notes for reviewers
Checklist: