Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/kubernetes/e2e/features/deployer: update tests #10158

Merged
merged 8 commits into from
Oct 3, 2024

Conversation

sam-heilbron
Copy link
Contributor

@sam-heilbron sam-heilbron commented Oct 2, 2024

Description

Update the e2e tests that validate the behavior of the deployer

Context

Internal slack context: https://solo-io-corp.slack.com/archives/G01EERAK3KJ/p1727892654195589

Interesting decisions

Testing steps

  • CI passes

Locally, I setup a kind cluster, and then ran:

 go test -v -timeout 600s ./test/kubernetes/e2e/tests -run ^TestK8sGateway$/Deployer$

and

 go test -v -timeout 600s ./test/kubernetes/e2e/tests -run ^TestK8sGatewayMinimalDefaultGatewayParameters$/Deployer$

and both succeeded

Notes for reviewers

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@solo-changelog-bot
Copy link

Issues linked to changelog:
https://github.com/solo-io/solo-projects/issues/6047

@github-actions github-actions bot added keep pr updated signals bulldozer to keep pr up to date with base branch work in progress signals bulldozer to keep pr open (don't auto-merge) labels Oct 2, 2024
@sam-heilbron sam-heilbron removed the work in progress signals bulldozer to keep pr open (don't auto-merge) label Oct 2, 2024
@@ -0,0 +1,91 @@
package deployer
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed this file to remove the deployer from the name, since that's the package we're in

Copy link

github-actions bot commented Oct 2, 2024

Visit the preview URL for this PR (updated for commit 1fcfd94):

https://gloo-edge--pr10158-sh-improve-e2e-tests-hgl9iu3g.web.app

(expires Thu, 10 Oct 2024 18:11:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677


err := s.testInstallation.Actions.Kubectl().ApplyFile(s.ctx, deployerProvisionManifestFile)
s.Require().NoError(err, "can apply manifest")
func (s *testingSuite) TestProvisionDeploymentAndService() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: i assume this is the original test that is being migrated here. The original test also did a simple curl/traffic test, do we want to add that here too, or do you think it's overkill?

i'm ok either way. we probably have enough other tests that do curls

@soloio-bulldozer soloio-bulldozer bot merged commit 0f6fd42 into main Oct 3, 2024
19 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the sh/improve-e2e-tests branch October 3, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants