Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Darwin Support for Vault and Consul e2e Deps #10156

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adds Darwin Support for Vault and Consul e2e Deps #10156

wants to merge 1 commit into from
+338 −41

Conversation

danehans
Copy link
Contributor

@danehans danehans commented Oct 2, 2024 •
edited by solo-changelog-bot bot
Loading

Description

Adds darwin OS support for the Consul and Vault dependencies used by e2e testing. When darwin is detected as the OS, the test suite will download the Vault or Consul binary from the HashiCorp release page.

Fixes #10152

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

BOT NOTES:
resolves #10152

@solo-changelog-bot
Copy link

Issues linked to changelog:
#10152

sam-heilbron
sam-heilbron approved these changes Oct 3, 2024
View reviewed changes
changelog/v1.18.0-beta25/issue_10152.yaml Outdated Show resolved Hide resolved
changelog/v1.18.0-beta25/issue_10152.yaml Outdated Show resolved Hide resolved
timflannagan
timflannagan approved these changes Oct 4, 2024
View reviewed changes
changelog/v1.18.0-beta25/issue_10152.yaml Outdated
@@ -0,0 +1,7 @@
changelog:
- type: FIX
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use type: NON_USER_FACING if there isn't any user-facing changes being made here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timflannagan thanks for the review. I used FIX since this PR fixes an issue that was labeled as a bug. Where can I find a doc that details the changelog schema?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sam-heilbron might know if there are any definitive docs -- hopefully OSS -- but the only thing that I found from GH search in the solo-io org was https://github.com/solo-io/go-utils/blob/f51fc89d9ae3d29522527e54bd0a508205f756e7/changelogutils/README.md?plain=1#L33.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the meantime, commit 74bbf4b updates the changelog with type: NON_USER_FACING.

changelog/v1.18.0-beta25/issue_10152.yaml Outdated Show resolved Hide resolved
test/services/utils/download.go Show resolved Hide resolved
@danehans danehans mentioned this pull request Oct 4, 2024
Open
@danehans
Adds Darwin Support for Vault and Consul e2e Deps
acec911 
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timflannagan timflannagan timflannagan approved these changes

@sam-heilbron sam-heilbron sam-heilbron approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The run-kube-e2e-tests for Gloo Fails on Mac
3 participants
@danehans @sam-heilbron @timflannagan