Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.14 - Discovery resource version err (#10118) #10138

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

bewebi
Copy link
Contributor

@bewebi bewebi commented Oct 1, 2024

Description

Backport #10118

Context

This cherry-pick omits tests added in the kubernetes/e2e as that directory/framework is not present in 1.14

Testing steps

Manual testing has not been done for 1.14, however the kube2e test running in CI should be sufficient to prove the bug has been fixed

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Co-authored-by: changelog-bot <changelog-bot>
Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label Oct 1, 2024
@solo-changelog-bot
Copy link

Issues linked to changelog:
#8635

@soloio-bulldozer soloio-bulldozer bot merged commit e22bec5 into v1.14.x Oct 1, 2024
15 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the discovery-resource-version-err-1.14 branch October 1, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants