1.17/fix/persistproxyspec

[nfuden]

Description

In 1.17 we introduced a regression for instances using persist proxy spec.

Persist proxy spec is mostly non-useful and will be removed in 1.18 but does have some smaller edge cases still supported in 1.17.
Unlike most of our resources proxies were called at a stage where we can accept a resource into our gloo system but fail to write any statuses back out along with failing to update the proxy CR at rest in etcd.

Code changes

Label selection cleanup

CI changes

Updated Upgrade tests to check for this step

Context

On upgrading from a version 1.13+ to 1.17+ with persist proxy spec set to true manual intervention was required prior to this wrk.

Testing steps

Thanks to sam https://github.com/solo-io/gloo-gateway-shared-resources/tree/main/issues/gloo/9968

Original reproduction was hampered by overly aggressive clean up scripts scheduled by default on local so this simplest set up helps alot.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

[solo-changelog-bot]

Issues linked to changelog:
#9968

[nfuden]

https://github.com/solo-io/gloo/actions/runs/10854177366/job/30124071891?pr=10025

test/kube2e/upgrade: spaces not tabs

84f0676

Shows it failing from persist