Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.25] Backport Handle STS Credentials Region (#267) #269

Merged
merged 1 commit into from
Sep 13, 2023
Merged

[v1.25] Backport Handle STS Credentials Region (#267) #269

merged 1 commit into from
Sep 13, 2023

Conversation

ben-taussig-solo
Copy link
Contributor

Description

  • Backport Handle STS Credentials Region #267 to v1.25.x
  • This resolves an issue where assuming a secondary role using an EKS ServiceAccount would fail when the region of the EKS cluster/OIDC provider used to authenticate the assumeRole request was not us-east-1

@ben-taussig-solo
Handle STS Credentials Region (#267)
2434651 
* add new field to ServiceAccountCredentials for sts region

* support new field

* support new setting in tests

* add changelog entry

* remove typo ffrom sts_credentials_provider_test.cc

* updae connection pool test

* update lambda integration test

* remove stray log messages

* relocate changelog entry

* allow region to be unset

* log credential scope mismatch on failure

* add testing against credentialscopemismatch

* update proto comment for new field
@solo-changelog-bot
Copy link

Issues linked to changelog:
solo-io/gloo#8578

@soloio-bulldozer soloio-bulldozer bot merged commit bf024d9 into release-v1.25 Sep 13, 2023
2 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the handle-sts-credentials-region-one-twenty-five branch September 13, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfuden nfuden nfuden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ben-taussig-solo @nfuden