Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI on Rails 6 #71

Merged
merged 9 commits into from
Sep 12, 2019
Merged

Fix CI on Rails 6 #71

merged 9 commits into from
Sep 12, 2019

Conversation

aldesantis
Copy link
Member

No description provided.

@aldesantis aldesantis self-assigned this Sep 12, 2019
@aldesantis aldesantis force-pushed the bugfix/rails-6-sqlite branch from 0a8d1d7 to 3016d9e Compare September 12, 2019 12:52
In Rails 6, this statement fails because Rails thinks the foreign
key does not exist for some reason. Since the remove_foreign_key
call is not needed because the column is removed in the subsequent
statement, we can remove it altogether.
@aldesantis aldesantis changed the title Relax sqlite3 dependency for Rails 6 compatibility Fix CI on Rails 6 Sep 12, 2019
@aldesantis aldesantis merged commit 4901314 into master Sep 12, 2019
@aldesantis aldesantis deleted the bugfix/rails-6-sqlite branch September 12, 2019 14:07
jmflannery added a commit to Braidio/solidus_subscriptions that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant