Fixes admin sorting on fields without a natural order #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the fields that allow sorting in the admin have a natural order (id, created_at, etc), so sorting on them asc/desc makes sense and works. However, fields like "state" and "processing", will only have no natural ordering and sorting on them will only group them together. This is really stange when you're paginating because records on page 2, can come back up on page 3. This fixes that by adding a second ordering by id: :asc on those fields.
spaghetticode
approved these changes
Aug 2, 2019
There was a problem hiding this comment.
@mdesantis @seantaylor these changes look good to me, thank you 🍰
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the fields that allow sorting in the admin have a natural
order (id, created_at, etc), so sorting on them asc/desc makes sense
and works. However, fields like "state" and "processing", will only
have no natural ordering and sorting on them will only group them
together. This is really stange when you're paginating because records
on page 2, can come back up on page 3.
This fixes that by adding a second ordering by id: :asc on those fields.