Fix filtering by line item in admin #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to scope subscriptions tied to a particular variant, instead of having to hunt down the specific line item when filtering. This also restructures the query in the view to avoid N+1s. On a store with 100K subscriptions the query and relative map take ~30ms.
stefano-sarioli
suggested changes
Jan 3, 2023
|
|
||
| <%= | ||
| f.select( | ||
| :with_line_item, | ||
| options_for_select(::SolidusSubscriptions::LineItem.joins(:subscribable).map { |item| [ item.subscribable.name, item.id ]}, params.dig(:q, :with_line_item)), | ||
| :with_subscribable, |
There was a problem hiding this comment.
More than a select field, this calls for a search field that does an API call to avoid the query altogether when loading the page. WDYT?
There was a problem hiding this comment.
Sorry I've seen this too late. I think this would be an even better UX, especially in stores with lots of subscribable variants. I'll open a ticket for it.
There was a problem hiding this comment.
That's a great idea. I merged this as is because this fixes a bug, but this improvement would be great.
|
Thank you @nirebu and @stefano-sarioli (and @kennyadsl )! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #274
This PR fixes the above issue by changing how the admin scopes subscriptions tied to a particular variant, instead of having to hunt down the specific line item when filtering them.
This also restructures the query in the view to avoid N+1s. On a store with 100K subscriptions the query and relative map take ~30ms.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):