Set default config currency to subscription #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luca-landa
force-pushed
the
luca-landa/set-default-currency-to-subscription
branch
6 times, most recently
from
63ccb1a to
6920473
Compare
aldesantis
reviewed
Mar 6, 2021
| @@ -311,6 +312,10 @@ def set_payment_method | |||
| end | |||
| end | |||
|
|
|||
| def set_currency | |||
| self.currency = ::Spree::Config[:currency] if self[:currency].nil? | |||
There was a problem hiding this comment.
Can this be simplified as self.currency ||= ::Spree::Config.currency?
luca-landa
force-pushed
the
luca-landa/set-default-currency-to-subscription
branch
from
6920473 to
54f91f6
Compare
ChristianRimondi
approved these changes
Mar 12, 2021
luca-landa
force-pushed
the
luca-landa/set-default-currency-to-subscription
branch
2 times, most recently
from
f98c750 to
7603279
Compare
Also add a spec that covers manual subscription creation from admin panel.
luca-landa
force-pushed
the
luca-landa/set-default-currency-to-subscription
branch
from
7603279 to
03a3f2c
Compare
luca-landa
force-pushed
the
luca-landa/set-default-currency-to-subscription
branch
from
75bb043 to
6e7d333
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #207, setting the currency value to the default
Spree::Configone.It also adds a UI test for subscription creation from admin panel.