Use name in customer serializer
#200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solidus 3.0 removes `first_name` and `last_name` from `Spree::Address` so we should replace them with `name`. The Churn Buster documentation would suggest it's OK to pass any customer properties we need, but I have yet to get a developer account to verify.
|
I believe this is ready for review. Unfortunately I don't have a Churn Buster account and they seem to require a credit card. Is there anyone who has an account to test with or can confirm the API change is OK? |
|
@nvandoorn this should be okay! The properties object accepts any keys we want to pass it. |
aldesantis
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solidus 3.0 removes
first_nameandlast_namefromSpree::Addressso we should replace them with
name. The Churn Buster documentationwould suggest it's OK to pass any customer properties we need, but I
have yet to get a developer account to verify.
Leaving this in draft until I can verify with a Churn Buster developer account.
Closes #194.