Fix DefaultCustomer permission set giving guests access to admin #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldesantis
force-pushed
the
aldesantis/fix-default-customer-permissions
branch
from
3906e79 to
2d0b5bf
Compare
The DefaultCustomer permission set would allow guests to see the subscriptions list (although they wouldn't be able to see any subscriptions).
CanCan requires `authorize!` calls to specify the name of the action as a symbol, if that's how it was specified in the ability.
aldesantis
force-pushed
the
aldesantis/fix-default-customer-permissions
branch
from
2d0b5bf to
9ac1fec
Compare
mtylty
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with the DefaultCustomer permission set, which allowed guest users to access the subscription admin page (although they wouldn't have access to any subscriptions).