Fix default permission set breaking accessible_by #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldesantis
force-pushed
the
aldesantis/permissions-fix
branch
3 times, most recently
from
6e6ddb7 to
4dcb253
Compare
aldesantis
force-pushed
the
aldesantis/permissions-fix
branch
3 times, most recently
from
606a261 to
44093af
Compare
With an AR scope, `#accessible_by` can be properly used.
aldesantis
force-pushed
the
aldesantis/permissions-fix
branch
from
44093af to
f55ce37
Compare
CanCan 2 complains about not being able to merge abilities that use an ActiveRecord scope, so we need to use an SQL string instead.
aldesantis
changed the title
aldesantis
changed the title
aldesantis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an ActiveRecord scope to our default permission set, so that
#accessible_bycan be used withSolidusSubscriptions::Subscriptiononce more.