Store payment method and source on subscriptions #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldesantis
changed the title
aldesantis
changed the title
aldesantis
force-pushed
the
aldesantis/subscription-payment-source
branch
3 times, most recently
from
9331b3f to
5a7da65
Compare
aldesantis
changed the title
This allows each subscription to have its own payment method and source. It also allows having subscriptions with payment methods that aren't credit cards, which is useful if you want e.g. to allow users to pay by check/wire transfer.
aldesantis
force-pushed
the
aldesantis/subscription-payment-source
branch
8 times, most recently
from
a0530ae to
97ef706
Compare
aldesantis
force-pushed
the
aldesantis/subscription-payment-source
branch
from
97ef706 to
626dd1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #116.
Implements the ability to have different payment methods and sources on each subscription. The payment information is copied from the order that originated the subscription, when possible.
Because the payment method is also stored, this PR also opens up the possibility of charging subscriptions via non-credit-card payment methods such as checks or wire transfers. All you have to do is set the right
payment_methodon the subscription and not set thepayment_source.