Only load permitted attributes once #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
reviewed
May 23, 2017
lib/solidus_subscriptions/engine.rb
Outdated
|
|
||
| initializer 'solidus_subscriptions.configs', before: "spree.register.payment_methods" do | ||
| initializer 'require subscription lib helpers' do | ||
| require 'solidus_subscriptions/permitted_attributes' |
There was a problem hiding this comment.
Are you requiring this line twice? Why do we need an initializer block for requiring files?
There was a problem hiding this comment.
Good catch! I didnt mean to add it in twice. You might be right. I wasnt sure if it was better to require this in an initializer or simple at the top of the engine along side spree/core.
I think I prefer the latter, so I will make that change :)
Previous Behaviour: The to_prepare block was reloading the permitted attributes module. This resulted in the subscription parameters being appended to the spree premitted attributes multiple times. New behaviour: Do not auto load the lib directory Only load the permitted attributes once during the initalization process
qr8r
force-pushed
the
duplicated_permitted_attributes
branch
from
c401903 to
c61f4d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behaviour:
The to_prepare block was reloading the permitted attributes module. This
resulted in the subscription parameters being appended to the spree
premitted attributes multiple times.
New behaviour:
Do not auto load the lib directory
Only load the permitted attributes once during the initalization process