Stop depending on solidus_dev_support #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elia
force-pushed
the
elia/gem-releasing
branch
from
f090114 to
2d991d0
Compare
elia
force-pushed
the
elia/gem-releasing
branch
3 times, most recently
from
fa3efa4 to
42b0326
Compare
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 27 27
Lines 489 489
=======================================
Hits 487 487
Misses 2 2 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
waiting-for-dev
suggested changes
Apr 17, 2023
elia
changed the title
waiting-for-dev
approved these changes
Apr 18, 2023
waiting-for-dev
suggested changes
Apr 18, 2023
There was a problem hiding this comment.
Sorry @elia, we still need to remove the instructions on the README so they don't get staled. The wiki should be the unique source of truth.
elia
force-pushed
the
elia/gem-releasing
branch
from
42b0326 to
68bebb3
Compare
|
@waiting-for-dev done ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With the new way of testing solidus extensions (through full rails installations) we no longer have much to gain from using solidus_dev_support.
Specifically the only two things we were using it for were:
Rubocop rules
We just had a few dev-support adjustments over the "relaxed" rubocop style, but we also had a handful of local rules.
It seems ok to just import the original list and move from there, all modern tooling will adapt to whatever rules are in the repo (language servers, formatters, etc.).
Releasing
The dev-support releasing toolchain starter at a time in which GitHub releases were not so convenient (if they existed at all). Now it's super easy to store the changelog there directly and be generated with one click.
This of course is ok for extensions as the have a smaller scope and simpler changes (vs. Solidus).
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: