Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain compatibility with Solidus 3.0 Address#name #100

Closed
wants to merge 1 commit into from

Conversation

brchristian
Copy link
Contributor

Solidus 3.0 switched from Address#first_name and Address#last_name to simply Address#name -- and also removed the Address#full_name accessor for good measure. (See solidusio/solidus#3458)

This caused the solidus_stripe specs to fail on the Solidus master branch.

This PR accommodates the new Address format in Solidus 3.0 while maintaining backwards compatibility with 2.11, 2.10, and older versions of Solidus. It fixes the specs which are currently broken in Solidus 3.0.

@brchristian brchristian changed the title maintain compatibility with Solidus 3.0 Address#name Maintain compatibility with Solidus 3.0 Address#name Jan 29, 2021
@brchristian
Copy link
Contributor Author

brchristian commented Jan 29, 2021

Note: This may already have been fixed by #99. If so, I fully support the merging of #99, which has an alternate implementation to this PR and which also addresses a number of deprecation warnings.

@kennyadsl
Copy link
Member

Thanks anyway @brchristian. I appreciate the help effort!

@brchristian brchristian deleted the single_name_field branch May 5, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants