Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update orders controller and specs to match Solidus #52

Merged
merged 2 commits into from
Jun 12, 2020
Merged

Update orders controller and specs to match Solidus #52

merged 2 commits into from
Jun 12, 2020

Conversation

dinohamzic
Copy link
Contributor

@dinohamzic dinohamzic commented Jun 12, 2020 •
edited
Loading

Description

Updates in Solidus caused the specs for the orders controller to break. Porting the new version of the file from Solidus fixes the issue.

These are the 2 PRs that updated the storefront files:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@dinohamzic dinohamzic added the bug Something isn't working label Jun 12, 2020
@dinohamzic dinohamzic self-assigned this Jun 12, 2020
@dinohamzic dinohamzic force-pushed the bugfix/port-new-solidus-changes branch from ed5155a to 5e271fb Compare June 12, 2020 07:45
@dinohamzic dinohamzic changed the title Update orders controller to match Solidus Update orders controller and specs to match Solidus Jun 12, 2020
kennyadsl
kennyadsl approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 let's link the PRs on Solidus that introduced these changes.

@dinohamzic
Copy link
Contributor Author

👍 let's link the PRs on Solidus that introduced these changes.

Done!

@dinohamzic dinohamzic merged commit 6e54c6e into master Jun 12, 2020
@dinohamzic dinohamzic deleted the bugfix/port-new-solidus-changes branch June 12, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@aleph1ow aleph1ow Awaiting requested review from aleph1ow

@blocknotes blocknotes Awaiting requested review from blocknotes

Assignees

@dinohamzic dinohamzic

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dinohamzic @kennyadsl