Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add separate admin locale page #83

Merged
merged 1 commit into from
Feb 8, 2017
Merged

Add separate admin locale page #83

merged 1 commit into from
Feb 8, 2017

Conversation

jhawthorn
Copy link
Contributor

No description provided.

@jhawthorn jhawthorn mentioned this pull request Feb 7, 2017
Closed
@jhawthorn jhawthorn force-pushed the admin_locale_page branch 2 times, most recently from 28bb739 to 0bd2d42 Compare February 8, 2017 00:02
tvdeyen
tvdeyen approved these changes Feb 8, 2017
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tvdeyen tvdeyen merged commit b6f4ac3 into solidusio:master Feb 8, 2017
@tvdeyen
Copy link
Member

tvdeyen commented Feb 8, 2017

We should raise the version and set the supported solidus version to >= 2.2

@tvdeyen
Copy link
Member

tvdeyen commented Feb 8, 2017

No. Not necessary. Ignore me. This even works for older Solidus versions. Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhawthorn @tvdeyen