Convert de translations from solidus 1.2 -> 1.3 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luukveenis
force-pushed
the
update-de-translations
branch
from
ad7b819 to
09e0131
Compare
Fixes wrong state vs. status de translations
|
Thank you Luuk and Thomas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes made to admin translations in solidus moved many of the keys. This was done to better use the ActiveModel translation conventions.
I wrote a script that scans through the locale files in solidus_i18n looking for missing keys when compared to
en.ymlin core. Since these translations are just moved, the script attempts to make the same moves in this locale as were made for english.Reviews would be appreciated to find any blatant mistranslations.