Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix travis build #137

Merged
merged 1 commit into from
Dec 18, 2018
Merged

fix travis build #137

merged 1 commit into from
Dec 18, 2018

Conversation

ccarruitero
Copy link
Contributor

@ccarruitero ccarruitero commented Nov 6, 2018 •
edited
Loading

Removing unused chromedriver-helper gem fix the build. Aside, is not necessary install chrome in travis too.

@ccarruitero ccarruitero changed the title remove chrome addon from travis config fix travis build Nov 7, 2018
aitbw
aitbw approved these changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@aitbw aitbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kennyadsl kennyadsl merged commit 13ccaf8 into solidusio:master Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aitbw aitbw aitbw approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ccarruitero @kennyadsl @aitbw