Version 2.0 #122

jhawthorn · 2018-04-06T21:32:00Z

This removes almost all of the functionality from the extension in favour of the new functionality which is built-in to Solidus itself.

This proposed version 2.0 of solidus_i18n provides nothing other than locale files, doesn't require deface, and doesn't do any class_eval or module prepends.

Functionality moved to Solidus itself:

Frontend locale selector Add locale selector to frontend nav bar solidus#2683
Per-store locales Add per-store configurable locales solidus#2674
LocaleController override Make frontend's LocaleController compatible with solidus_i18n solidus#2626
set_user_language behaviour solidusio/solidus@568ca0b

Removed functionality:

Remove SolidusI18n::Config (this shouldn't exist now that there are per-store locales)
Remove weird country name magic (we want to remove this anyways, see Remove i18n_data dependency #108, Switch to I18n::Backend::Simple.new due to i18n-js compatibility #106)
Remove routing filter (this can be added by users, and should be recommended in the README)

TODO:

Upgrade instructions/changelog
README instructions for routing-filter gem
Remove rails-i18n and kaminari-i18n
Remove specs

tvdeyen · 2018-04-06T22:45:34Z

Tested while working on solidusio/solidus#2684. Working great so far 👍 and fixes lots of bugs while switching admin locales. We should drop < 2.6 support IMO. There is still a version working for < 2.6 and translations files can easily be updated in the store application (this is recommended anyway)

tvdeyen · 2018-04-06T22:47:15Z

README.md


-    bin/rails g solidus_i18n:install
+1. Add gem to your `Gemfile`, then run `bundle install`


Add this gem to your ...

tvdeyen · 2018-04-06T22:53:19Z

We should remove rails-i18n and kaminari-i18n dependencies as well and encourage people to copy over the locale files they actually need over into their host app. I doubt anybody is using all locales available in their stores. Loading so many locales all the time only bloats their apps.

tvdeyen · 2018-04-06T22:55:09Z

solidus_i18n.gemspec

  s.add_runtime_dependency 'solidus_core', ['>= 1.1', '< 3']
  s.add_runtime_dependency 'solidus_support'
-  s.add_runtime_dependency 'deface', '~> 1.0'

  s.add_development_dependency 'byebug'
  s.add_development_dependency 'capybara', '~> 2.17'


Do we still have tests left, then?

I need to remove them still. I'd like some extremely simple tests (basically, verify YAML is valid). We won't need capybara

As far as I can tell engines do this by default and this is unnecessary.

We no longer have any

These will be built-in to Solidus in version 2.6.

We no longer have any files which would be autoloaded by this. This shouldn't really be done anyways (making lib autoloaded, use app).

We no longer have any functionality, so just test that we're adding the locales we want to.

Users can add this themselves

jhawthorn · 2018-04-26T23:55:19Z

This is ready to go

I'm not sure what we should do to support versions < 2.6. Maybe a solidus_i18n_backports gem to inject the new Solidus 2.6 functionality into old versions?

tvdeyen

I'm not sure what we should do to support versions < 2.6. Maybe a solidus_i18n_backports gem to inject the new Solidus 2.6 functionality into old versions?

I don’t think we need to. Maybe we release a 1.3 version that restricts the version of Solidus to < 2.6?

tvdeyen

Do we still need solidus_support

tvdeyen · 2018-04-27T05:29:44Z

solidus_i18n.gemspec

-  s.add_runtime_dependency 'i18n_data', '~> 0.7.0'
-  s.add_runtime_dependency 'rails-i18n', ['>= 4.0.1', '< 6']
-  s.add_runtime_dependency 'kaminari-i18n', '~> 0.5.0'
-  s.add_runtime_dependency 'routing-filter', '~> 0.6.0'
  s.add_runtime_dependency 'solidus_core', ['>= 1.1', '< 3']
  s.add_runtime_dependency 'solidus_support'


Do we still need solidus_support? Couldn’t find any usages anymore.

tvdeyen reviewed Apr 6, 2018

View reviewed changes

README.md Outdated

bin/rails g solidus_i18n:install

1. Add gem to your `Gemfile`, then run `bundle install`

Copy link

Member

tvdeyen Apr 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this gem to your ...

tvdeyen reviewed Apr 6, 2018

View reviewed changes

jhawthorn and others added 18 commits April 26, 2018 14:58

Remove all functionality

c024882

Remove migrations

d79742e

Remove routes

000bd54

Remove unnecessary dependencies

fdfc42c

Remove country_names hack

1dcd19d

Start version 2.0

fe78c7c

Remove routing filter config

31be5f7

Remove weird locale load_path configuration

f16d9dc

As far as I can tell engines do this by default and this is unnecessary.

Remove SolidusI18n::Config

a0b0a6a

Remove decorators config in engine

a3d5d1c

We no longer have any

Remove controller_locale_helper

bd41110

Remove SolidusI18n::Locale helpers

ca424ee

These will be built-in to Solidus in version 2.6.

Remove autoloading from lib

d74c837

We no longer have any files which would be autoloaded by this. This shouldn't really be done anyways (making lib autoloaded, use app).

Remove install generator

ceff3cd

Update README for version 2.0

8a886ea

Remove all but the most basic specs

c77aa2f

We no longer have any functionality, so just test that we're adding the locales we want to.

Remove rails-i18n and kaminari-i18n

a672aec

Users can add this themselves

Improve README for 2.0

3934a3d

jhawthorn force-pushed the maybe_version_2_0 branch from bd08de0 to 3934a3d Compare April 26, 2018 21:58

jhawthorn changed the title ~~RFC: Version 2.0 (maybe)~~ Version 2.0 Apr 26, 2018

tvdeyen approved these changes Apr 27, 2018

View reviewed changes

tvdeyen reviewed Apr 27, 2018

View reviewed changes

Remove solidus_support

0ed3ff0

jhawthorn merged commit 3c4787a into solidusio:master May 2, 2018

jhawthorn mentioned this pull request May 2, 2018

Remove i18n_data dependency #108

Closed

jhawthorn mentioned this pull request May 2, 2018

Switch to I18n::Backend::Simple.new due to i18n-js compatibility #106

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Version 2.0 #122

Version 2.0 #122

jhawthorn commented Apr 6, 2018 •

edited

Loading

tvdeyen commented Apr 6, 2018

tvdeyen Apr 6, 2018

tvdeyen commented Apr 6, 2018

tvdeyen Apr 6, 2018

jhawthorn Apr 9, 2018

jhawthorn commented Apr 26, 2018 •

edited

Loading

tvdeyen left a comment

tvdeyen left a comment

tvdeyen Apr 27, 2018

jhawthorn Apr 27, 2018


		bin/rails g solidus_i18n:install
		1. Add gem to your `Gemfile`, then run `bundle install`

Version 2.0 #122

Version 2.0 #122

Conversation

jhawthorn commented Apr 6, 2018 • edited Loading

tvdeyen commented Apr 6, 2018

tvdeyen Apr 6, 2018

Choose a reason for hiding this comment

tvdeyen commented Apr 6, 2018

tvdeyen Apr 6, 2018

Choose a reason for hiding this comment

jhawthorn Apr 9, 2018

Choose a reason for hiding this comment

jhawthorn commented Apr 26, 2018 • edited Loading

tvdeyen left a comment

Choose a reason for hiding this comment

tvdeyen left a comment

Choose a reason for hiding this comment

tvdeyen Apr 27, 2018

Choose a reason for hiding this comment

jhawthorn Apr 27, 2018

Choose a reason for hiding this comment

jhawthorn commented Apr 6, 2018 •

edited

Loading

jhawthorn commented Apr 26, 2018 •

edited

Loading