Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Travis CI and Capybara driver #111

Merged
merged 1 commit into from
Mar 1, 2018

Conversation

kennyadsl
Copy link
Member

@kennyadsl kennyadsl commented Feb 15, 2018

On #95 there is a feature that uses MutationObserver code in solidus.

This feature is not supported by the old Poltergeist driver, so I aligned the Capybara usage with what we do on solidus master

@kennyadsl kennyadsl self-assigned this Feb 15, 2018
@kennyadsl kennyadsl force-pushed the kennyadsl/selenium-headless branch 8 times, most recently from 3bf960f to 748dc12 Compare February 15, 2018 13:05
@kennyadsl kennyadsl changed the title Use selenium headless chrome driver for feature specs Update Travis CI and Capybara driver Feb 15, 2018
@kennyadsl kennyadsl added this to the 2.0 milestone Feb 15, 2018
@kennyadsl kennyadsl force-pushed the kennyadsl/selenium-headless branch from 748dc12 to e65e590 Compare February 28, 2018 10:02
this is needed since old versions of Capybara don't support
MutationObserver, which is now part of master.
@kennyadsl kennyadsl force-pushed the kennyadsl/selenium-headless branch from 8aea238 to c440402 Compare March 1, 2018 10:46
@kennyadsl kennyadsl merged commit 14039be into master Mar 1, 2018
@kennyadsl kennyadsl deleted the kennyadsl/selenium-headless branch March 1, 2018 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant