Improve Locale.all and all_locales_options #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
force-pushed
the
locales_all
branch
from
f460d57 to
37e344b
Compare
Previously this used Dir[] inside the locales directory. This didn't allow for locales coming from different gems. For this reason it also didn't include :en.
Previously, we listed both en-IN as "English (UK)" and es-MX as "Castellano (ES)". This commit adds a spec to ensure that the locales have a unique names and updates the two offending locales.
jhawthorn
force-pushed
the
locales_all
branch
from
37e344b to
0a4451e
Compare
jhawthorn
changed the title
tvdeyen
approved these changes
Feb 9, 2018
| File.join(File.dirname(__FILE__), '/../../config/locales') | ||
| def self.all | ||
| I18n.available_locales.select do |locale| | ||
| I18n.t(:spree, locale: locale, fallback: false, default: nil) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to scan the
config/localesdirectory of this project to determine available locales. This misseden, so that was added manually in a helper.This PR changes that to instead scan
I18n.available_localesfor locales which have anything undert(:spree)and removes the hardcodedEnglish (EN)(which is now also correctly "English (US)").It also fixes
en-INandes-MXmisidentifying as duplicated"English (UK)"and"Castellano (ES)"respectively.