-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing tests (most of them), get basic features working with Solidus #1
Conversation
…ations before it's initialized
…nly on Solidus master
Test suite is now green At this point the goal was strictly to port the extension so design is unchanged
It's monkey patch by the extension, it might cleaner to remove it from the core and define it properly in this extension
cc: @jhawthorn for review Once everything is ready, I suggest publishing a stable v1.0 branch and keeping master for active development |
👍 Thanks! |
I suggest to make the version match the solidus version. So 1.1.0 as this is the current release of solidus. Maybe make a 1.0 branch without the cart link? |
ping @alepore |
Gemfile had Solidus master instead of v.1.0 so tests were passing even though the _cart_link html was missing a param. V.1.0 needs an additional override added by #8e97b6aad Not sure why Ruby 2.2. with Postgres is failing though, investigating EDIT : Restarted the Travis build, now passing, not sure why it failed the first time (maybe just an error during the build?) |
Fix failing tests (most of them), get basic features working with Solidus
This fix mosts of the failing spec except those from this file :
scenario 'selected translation is applied'
scenario 'JS cart link is translated'
cc: @jhawthorn for failing capybara spec
Point to consider
The cart_decorator.js.coffee is there as a bandaid for Solidus 1.0 since the exact same code is present in Solidus master but not on Solidus v1, would it be a good idea to backport the change in Solidus 1.0?
After this, the extension should be passing tests and providing the necessary features so we can move forward with Globalize
TO DO
Analyze how we want to handle the differents upgrade paths because the included migrations could be problematic and might be not something we want to support forever (relating to dropping the translations table or not)