Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests (most of them), get basic features working with Solidus #1

Merged
merged 11 commits into from
Nov 27, 2015
Merged

Fix failing tests (most of them), get basic features working with Solidus #1

merged 11 commits into from
Nov 27, 2015

Conversation

fredericboivin
Copy link
Contributor

  1. Adapted the overrides to fit with the Solidus layout instead of Spree 3
  2. Remove code related to localized cart link (not needed with the latest Solidus master, cart link is smart about it)

This fix mosts of the failing spec except those from this file :

scenario 'selected translation is applied'
scenario 'JS cart link is translated'

cc: @jhawthorn for failing capybara spec

Point to consider

The cart_decorator.js.coffee is there as a bandaid for Solidus 1.0 since the exact same code is present in Solidus master but not on Solidus v1, would it be a good idea to backport the change in Solidus 1.0?

After this, the extension should be passing tests and providing the necessary features so we can move forward with Globalize

TO DO

Analyze how we want to handle the differents upgrade paths because the included migrations could be problematic and might be not something we want to support forever (relating to dropping the translations table or not)

@fredericboivin fredericboivin changed the title Development Fix failing tests (most of them), get basic features working with Solidus Nov 12, 2015
@fredericboivin
Copy link
Contributor Author

Test suite is now green

At this point the goal was strictly to port the extension so design is unchanged

  1. There is a locale controller in Solidus which looks like dead code : Solidus

It's monkey patch by the extension, it might cleaner to remove it from the core and define it properly in this extension

  1. The JS needed to localize cart_link is in the core for v.1.1 and master but not v.1.0 so it's included as a decorator in the extension since it rely on it: cart_decorator.js

  2. I added some regex in the spec because Capybara and the tests in the first comment are failing because it expect lower case while in the page it's uppercase

cc: @jhawthorn for review

Once everything is ready, I suggest publishing a stable v1.0 branch and keeping master for active development

@tvdeyen
Copy link
Member

tvdeyen commented Nov 26, 2015

👍 Thanks!

@tvdeyen
Copy link
Member

tvdeyen commented Nov 26, 2015

I suggest to make the version match the solidus version. So 1.1.0 as this is the current release of solidus. Maybe make a 1.0 branch without the cart link?

@tvdeyen
Copy link
Member

tvdeyen commented Nov 26, 2015

ping @alepore

@tvdeyen tvdeyen added this to the 1.0 milestone Nov 26, 2015
@fredericboivin
Copy link
Contributor Author

Gemfile had Solidus master instead of v.1.0 so tests were passing even though the _cart_link html was missing a param. V.1.0 needs an additional override added by #8e97b6aad

Not sure why Ruby 2.2. with Postgres is failing though, investigating

EDIT : Restarted the Travis build, now passing, not sure why it failed the first time (maybe just an error during the build?)

@fredericboivin fredericboivin mentioned this pull request Nov 27, 2015
tvdeyen added a commit that referenced this pull request Nov 27, 2015
Fix failing tests (most of them), get basic features working with Solidus
@tvdeyen tvdeyen merged commit 42de96e into solidusio:master Nov 27, 2015
@fredericboivin fredericboivin deleted the development branch November 27, 2015 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants