Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make specs compliant with new taxon factories #35

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

kennyadsl
Copy link
Member

Summary

In Solidus core we improved how taxon factories are built and we need to reflect that change in the frontend specs as well.

Ref solidusio/solidus#4851

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

In Solidus core we improved how taxon factories are built
and we need to reflect that change in the frontend specs
as well.

Ref solidusio/solidus#4851
@kennyadsl kennyadsl added the bug Something isn't working label Apr 21, 2023
@kennyadsl kennyadsl self-assigned this Apr 21, 2023
@waiting-for-dev waiting-for-dev merged commit a7e5554 into master Apr 21, 2023
@waiting-for-dev waiting-for-dev deleted the kennyadsl/fix-taxon-spec branch April 21, 2023 09:18
@waiting-for-dev waiting-for-dev mentioned this pull request May 3, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants