Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Lint code on GH actions #6064

Merged
merged 1 commit into from
Jan 15, 2025
Merged

CI: Lint code on GH actions #6064

merged 1 commit into from
Jan 15, 2025

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jan 9, 2025

Summary

Linting runs parallel to testing and circle ci is
slow and our free plan has limited resources.

Also GH actions are better integrated and has better dev feedback.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@tvdeyen tvdeyen requested a review from a team as a code owner January 9, 2025 16:59
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Jan 9, 2025
@tvdeyen tvdeyen requested a review from a team January 15, 2025 07:29
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@tvdeyen tvdeyen mentioned this pull request Jan 15, 2025
Linting runs parallel to testing and circle ci is
slow and our free plan has limited resources.

Also GH actions are better integrated and has better dev
feedback.
@tvdeyen tvdeyen enabled auto-merge January 15, 2025 10:49
@tvdeyen tvdeyen merged commit 3675af2 into solidusio:main Jan 15, 2025
15 of 16 checks passed
@tvdeyen tvdeyen deleted the lint-on-gh branch January 15, 2025 11:09
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.58%. Comparing base (332ed17) to head (7275966).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6064   +/-   ##
=======================================
  Coverage   89.58%   89.58%           
=======================================
  Files         801      801           
  Lines       18275    18275           
=======================================
  Hits        16371    16371           
  Misses       1904     1904           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen added backport-v4.1 Backport this pull-request to v4.1 backport-v4.2 Backport this pull-request to v4.2 backport-v4.3 Backport this pull-request to v4.3 backport-v4.4 Backport this pull-request to v4.4 labels Jan 15, 2025
Copy link

💔 Some backports could not be created

Status Branch Result
v4.1 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.1:
- Merge pull request #5459 from tvdeyen/revert-5367
v4.2 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.2:
- Run installer CI jobs for PR targeting Solidus 4.2+
- Merge pull request #5459 from tvdeyen/revert-5367
v4.3 Backport failed because of merge conflicts
v4.4

Manual backport

To create the backport manually run:

backport --pr 6064

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Copy link

💔 All backports failed

Status Branch Result
v4.1 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.1:
- Merge pull request #5459 from tvdeyen/revert-5367
v4.2 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.2:
- Run installer CI jobs for PR targeting Solidus 4.2+
- Merge pull request #5459 from tvdeyen/revert-5367
v4.3 Backport failed because of merge conflicts
v4.4 An unhandled error occurred. Please see the logs for details

Manual backport

To create the backport manually run:

backport --pr 6064

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Copy link

💔 All backports failed

Status Branch Result
v4.1 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.1:
- Merge pull request #5459 from tvdeyen/revert-5367
v4.2 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.2:
- Run installer CI jobs for PR targeting Solidus 4.2+
- Merge pull request #5459 from tvdeyen/revert-5367
v4.3 Backport failed because of merge conflicts
v4.4 An unhandled error occurred. Please see the logs for details

Manual backport

To create the backport manually run:

backport --pr 6064

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Copy link

💔 Some backports could not be created

Status Branch Result
v4.1 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.1:
- Merge pull request #5459 from tvdeyen/revert-5367
v4.2 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.2:
- Run installer CI jobs for PR targeting Solidus 4.2+
- Merge pull request #5459 from tvdeyen/revert-5367
v4.3 Backport failed because of merge conflicts
v4.4

Manual backport

To create the backport manually run:

backport --pr 6064

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@tvdeyen
Copy link
Member Author

tvdeyen commented Jan 15, 2025

💚 All backports created successfully

Status Branch Result
v4.3

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.1 Backport this pull-request to v4.1 backport-v4.2 Backport this pull-request to v4.2 backport-v4.3 Backport this pull-request to v4.3 backport-v4.4 Backport this pull-request to v4.4 changelog:repository Changes to the repository not within any gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants