Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solidus legacy promotions to promotions gemfile #6030

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Dec 10, 2024

Summary

This adds solidus_legacy_promotions to the :promotions group in the main Gemfile, so that rake tasks in solidus_legacy_promotions run in development mode.

It also removes some duplication in the main Gemfile, removing these warnings:

Your Gemfile lists the gem solidus_admin (>= 0) more than once.
You should probably keep only one of them.
Remove any duplicate entries and specify the gem only once.
While it's not a problem now, it could cause errors if you change the version of one of them later.
Your Gemfile lists the gem axe-core-rspec (~> 4.8) more than once.
You should probably keep only one of them.
Remove any duplicate entries and specify the gem only once.
While it's not a problem now, it could cause errors if you change the version of one of them later.
Your Gemfile lists the gem axe-core-capybara (~> 4.8) more than once.
You should probably keep only one of them.
Remove any duplicate entries and specify the gem only once.
While it's not a problem now, it could cause errors if you change the version of one of them later.
Your Gemfile lists the gem solidus_legacy_promotions (>= 0) more than once.
You should probably keep only one of them.
Remove any duplicate entries and specify the gem only once.
While it's not a problem now, it could cause errors if you change the version of one of them later.
Your Gemfile lists the gem solidus_backend (>= 0) more than once.
You should probably keep only one of them.
Remove any duplicate entries and specify the gem only once.
While it's not a problem now, it could cause errors if you change the version of one of them later.

`solidus_promotions` is tested with `legacy_promotions`, and needs this
dependency to be present in tests. This does not add `legacy_promotions`
as a runtime dependency.
Bundler is unhappy about duplicate entries in the Gemfile. This creates
a couple of new `group` statements that remove those duplications.

This makes the Gemfile harder to read, unfortunately.
@mamhoff mamhoff requested a review from a team as a code owner December 10, 2024 11:08
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.82%. Comparing base (2d5bda7) to head (8849ae3).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6030      +/-   ##
==========================================
- Coverage   89.51%   87.82%   -1.70%     
==========================================
  Files         787      477     -310     
  Lines       18120    11670    -6450     
==========================================
- Hits        16220    10249    -5971     
+ Misses       1900     1421     -479     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a non-blocking question on future plans.

Gemfile Show resolved Hide resolved
@kennyadsl kennyadsl merged commit 6aa6b22 into solidusio:main Dec 10, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:repository Changes to the repository not within any gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants