[4.2] Fix latest rubocop issues #5653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed with
rubocop -a
Using
rubocop -A
and verified they are safe.
Cherry Picked from bc3944d Co-Authored-By: Elia Schito <elia@schito.me>
github-actions
bot
added
changelog:solidus_api
This was referenced Feb 8, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## v4.2 #5653 +/- ##
=======================================
Coverage 88.86% 88.86%
=======================================
Files 607 607
Lines 14749 14749
=======================================
Hits 13106 13106
Misses 1643 1643 ☔ View full report in Codecov by Sentry. |
adammathys
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly backports fixes from bc3944d