[v3.4] Skip `ActionCable` for dummy apps #5628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
changelog:solidus_core
github-actions
bot
force-pushed
the
backport/v3.4/pr-5420
branch
from
8bb8c5e to
31fb9a2
Compare
We don't really use ActionCable for anything as far as I know. Having it makes installing Turbo/Stimulus in extensions harder. The installer for Turbo will look for a Gemfile in `Rails.root`, which is not there in case of the dummy app, and fail. If, however, `config/cable.yml` can't be found, the Turbo installer succeeds with a message that Turbo is installed, just without the broadcasting feature (which is alright for most apps I believe). (cherry picked from commit 3f8ad82)
github-actions
bot
force-pushed
the
backport/v3.4/pr-5420
branch
2 times, most recently
from
0ff96a9 to
22703b8
Compare
3 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## v3.4 #5628 +/- ##
==========================================
- Coverage 86.71% 86.70% -0.01%
==========================================
Files 579 579
Lines 14729 14730 +1
==========================================
Hits 12772 12772
- Misses 1957 1958 +1 ☔ View full report in Codecov by Sentry. |
tvdeyen
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintov3.4:Questions ?
Please refer to the Backport tool documentation