Fix issues raised by ERB and JS linting #5457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update the ECMAScript version used - add proper ignore patterns - switch to the recommended ruleset which doesn't require additional packages
github-actions
bot
added
changelog:solidus_backend
elia
force-pushed
the
elia/restore-eslint-checks
branch
from
d3c608b to
8c44f6e
Compare
elia
force-pushed
the
elia/restore-eslint-checks
branch
from
8c44f6e to
9a90dcd
Compare
elia
force-pushed
the
elia/restore-eslint-checks
branch
from
9a90dcd to
c450edb
Compare
Codecov Report
@@ Coverage Diff @@
## main #5457 +/- ##
=======================================
Coverage 88.91% 88.91%
=======================================
Files 614 614
Lines 14829 14829
=======================================
Hits 13185 13185
Misses 1644 1644 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rainerdema
reviewed
Oct 25, 2023
core/app/views/spree/order_mailer/inventory_cancellation_email.html.erb
Outdated
Show resolved
Hide resolved
tvdeyen
reviewed
Oct 25, 2023
Those two groups are useful in order to get quick bundle install times when the CI or GH action need to run a task only related to those gems.
elia
force-pushed
the
elia/restore-eslint-checks
branch
from
c450edb to
03fd580
Compare
rainerdema
approved these changes
Oct 25, 2023
jarednorman
approved these changes
Oct 25, 2023
elia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We used to rely on the now abandoned
houndservice for linting, this PR restores checks on JS and ERB.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: