Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline the release scripts #5440

Merged
merged 9 commits into from
Oct 25, 2023
Merged

Streamline the release scripts #5440

merged 9 commits into from
Oct 25, 2023

Conversation

elia
Copy link
Member

@elia elia commented Oct 17, 2023

Summary

Simplify and streamline the release tools, using a subclass of Gem::Version for manipulating versions makes the code more linear and understandable. This started as a small fix for regenerating the draft changelog.

  • Move all scripts under bin/release/
  • Use the top-level gemfile
  • Remove redundant scripts and support classes
  • Use a more direct style to improve readability

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Oct 17, 2023
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Oct 17, 2023
@elia elia force-pushed the elia/release-dev-tools-update branch from 6ad3451 to 2b6c3dd Compare October 17, 2023 09:43
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #5440 (8af0b20) into main (af2803a) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5440   +/-   ##
=======================================
  Coverage   88.91%   88.91%           
=======================================
  Files         614      614           
  Lines       14830    14830           
=======================================
  Hits        13186    13186           
  Misses       1644     1644           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia requested a review from rainerdema October 18, 2023 14:06
elia added 3 commits October 24, 2023 12:38
- Bump the required dev-tools version for octokit
- Bump the release scripts Ruby version
Provide common `ROOT` and `OCTOKIT` constants with a reference to the
repo root and an octokit client.
This will help making version manipulation extremely easy and seamless.
@elia elia force-pushed the elia/release-dev-tools-update branch from 2b6c3dd to 9993748 Compare October 24, 2023 10:39
@elia elia marked this pull request as ready for review October 24, 2023 11:02
@elia elia requested a review from a team as a code owner October 24, 2023 11:02
bin/release/bump-version Outdated Show resolved Hide resolved
bin/release/bump-previous-minor-version Outdated Show resolved Hide resolved
@elia elia force-pushed the elia/release-dev-tools-update branch from 9993748 to 8af0b20 Compare October 25, 2023 08:48
@elia elia merged commit d479d6a into main Oct 25, 2023
4 checks passed
@elia elia deleted the elia/release-dev-tools-update branch October 25, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:repository Changes to the repository not within any gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants