-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline the release scripts #5440
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:repository
Changes to the repository not within any gem
label
Oct 17, 2023
elia
force-pushed
the
elia/release-dev-tools-update
branch
from
October 17, 2023 09:43
6ad3451
to
2b6c3dd
Compare
Codecov Report
@@ Coverage Diff @@
## main #5440 +/- ##
=======================================
Coverage 88.91% 88.91%
=======================================
Files 614 614
Lines 14830 14830
=======================================
Hits 13186 13186
Misses 1644 1644 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
- Bump the required dev-tools version for octokit - Bump the release scripts Ruby version
Provide common `ROOT` and `OCTOKIT` constants with a reference to the repo root and an octokit client.
This will help making version manipulation extremely easy and seamless.
elia
force-pushed
the
elia/release-dev-tools-update
branch
from
October 24, 2023 10:39
2b6c3dd
to
9993748
Compare
rainerdema
approved these changes
Oct 25, 2023
Make the release draft generator idempotent by relying on GitHub's generator we can list all involved PRs and fetch the updated title every time without needing a PR merge event.
elia
force-pushed
the
elia/release-dev-tools-update
branch
from
October 25, 2023 08:48
9993748
to
8af0b20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simplify and streamline the release tools, using a subclass of Gem::Version for manipulating versions makes the code more linear and understandable. This started as a small fix for regenerating the draft changelog.
bin/release/
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: