Add a deprecation warning for allow_promotions_any_match_policy = true #4991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
waiting-for-dev
approved these changes
Mar 22, 2023
RyanofWoods
suggested changes
Mar 22, 2023
We are going to remove this preference in Solidus 4.0. The only accepted value for who wants to upgrade is false. Ref solidusio#4304
This constant won't be needed anymore in 4.0 when we will remove
the any matching policy for promotion rules.
I tried to use a more simple ActiveSupport::Deprecation::DeprecatedObjectProxy
like:
MATCH_POLICIES = ActiveSupport::Deprecation::DeprecatedObjectProxy.new(
%w(all any),
"Spree::Promotion::MATCH_POLICIES is deprecated, please do not use it anymore.",
Spree::Deprecation
)
But it prints the deprecation warning twice for some reason. The
approach used in this commit will load the file that contains the
constant only when it's called, which will also print the warning.
kennyadsl
force-pushed
the
kennyadsl/deprecate-promotion-match-any
branch
from
cd9c7b8 to
bc82ebd
Compare
adammathys
approved these changes
Mar 27, 2023
waiting-for-dev
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We are going to remove this preference in Solidus 4.0, along with the possibility to create promotion rules with the "Any" match policy.
The only accepted value for those who want to upgrade is
false.Ref #4304
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: