-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spree::ProductDuplicator bug on price #4971
Spree::ProductDuplicator bug on price #4971
Conversation
Until v3.2.3 duplicating a product duplicated the price. Since v3.2.4 the product duplication does not duplicate the price. Looks like it comes from the PR solidusio#4639 :/ To fix it we duplicate all of the master prices on the new_product.
d58d896
to
00cac06
Compare
Codecov Report
@@ Coverage Diff @@
## master #4971 +/- ##
=======================================
Coverage 86.69% 86.69%
=======================================
Files 578 578
Lines 14685 14685
=======================================
Hits 12731 12731
Misses 1954 1954
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, @Roddoric! 🎉
@kennyadsl it should also be back-ported to v3.1 as the version 3.1.9 is also concerned |
@Roddoric you are right, done! |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Summary
Created to support #4970
Until v3.2.3 duplicating a product duplicated the price.
Since v3.2.4 the product duplication does not duplicate the price.
Looks like it comes from the PR #4639 :/
The code looks like price is supposed to be copied:
Spree::ProductDuplicator#duplicate_master
To fix it I duplicated all of the master prices on the new_product.master.
Looks like it work for the test and for our app.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: