Update Spree::Product scopes.rb to fix issue with 'descend_by_popularity' scope

[cmbaldwin]

Fixes issue "'disallow_raw_sql!': Query method called with non-attribute argument" for the Spree::Product scope 'descend_by_popularity'. Uses the Arel.sql method to build sanitized SQL.

Fixes #4968

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

• I have written a thorough PR description.
• I have kept my commits small and atomic.
• I have used clear, explanatory commit messages.

The following are not always needed:

• 📖 I have updated the README to account for my changes.
• 📑 I have documented new code with YARD.
• 🛣️ I have opened a PR to update the guides.
• ✅ I have added automated tests to cover my changes.
• 📸 I have attached screenshots to demo visual changes.

[waiting-for-dev]

Thanks, @cmbaldwin 🙌 Would you mind adding a regression test for that? 🙏

[cmbaldwin]

Thanks, @cmbaldwin 🙌 Would you mind adding a regression test for that? 🙏

I'm a novice at this, like I'm just learning rspec, is this acceptable?

[kennyadsl]

Thanks!

[waiting-for-dev]

Thanks!!!

[codecov]

Codecov Report

Merging #4969 (1f45cdd) into master (c09ead3) will decrease coverage by 0.79%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4969      +/-   ##
==========================================
- Coverage   86.69%   85.91%   -0.79%     
==========================================
  Files         578      531      -47     
  Lines       14685    13183    -1502     
==========================================
- Hits        12731    11326    -1405     
+ Misses       1954     1857      -97     

Impacted Files	Coverage Δ
core/app/models/spree/product/scopes.rb	63.80% <ø> (+0.95%)	⬆️
api/app/controllers/spree/api/states_controller.rb
.../app/controllers/spree/api/countries_controller.rb
...app/controllers/spree/api/line_items_controller.rb
api/lib/spree/api/responders/jbuilder_template.rb
api/lib/spree/api/config.rb
...ntrollers/spree/api/customer_returns_controller.rb
.../controllers/spree/api/option_values_controller.rb
api/lib/spree/api/testing_support/setup.rb
...p/controllers/spree/api/credit_cards_controller.rb
... and 39 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[kennyadsl]

Just for reference, this PR is making the test suite fail pretty consistently: https://app.circleci.com/pipelines/github/solidusio/solidus/4165/workflows/08e29e14-a001-406a-a924-be5443af3cf1/jobs/39599.

@cmbaldwin Do you want to take a look at it?

[kennyadsl]

@cmbaldwin I think I have a fix with #4979.

[cmbaldwin]

Thanks!

Sorry I was a bit busy with other things last week, didn't show up on my radar until just now.

I learned a bit from your fix, setting specific variables instead of 'let' and the create_list method. Cheers :)