Add back Variant#find_or_build_default_price #4960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
adammathys
approved these changes
Mar 1, 2023
spaghetticode
force-pushed
the
add-back-variant-find_or_build_default_price
branch
from
d8df32b to
ae37846
Compare
Codecov Report
@@ Coverage Diff @@
## master #4960 +/- ##
=======================================
Coverage 86.69% 86.69%
=======================================
Files 578 578
Lines 14681 14684 +3
=======================================
+ Hits 12728 12731 +3
Misses 1953 1953
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kennyadsl
added
type:bug
kennyadsl
reviewed
Mar 1, 2023
| def find_or_build_default_price | ||
| default_price_or_build | ||
| end | ||
| deprecate :find_or_build_default_price, deprecator: Spree::Deprecation |
There was a problem hiding this comment.
Suggested change
| deprecate :find_or_build_default_price, deprecator: Spree::Deprecation | |
| deprecate :find_or_build_default_price, :default_price_or_build, deprecator: Spree::Deprecation |
👆 I think this will generate a better deprecation message.
There was a problem hiding this comment.
We're trying to get better with yard documentation, so here we have a nice opportunity to use the @deprecated tag: https://rubydoc.info/gems/yard/file/docs/Tags.md#deprecated 🙂
waiting-for-dev
approved these changes
Mar 2, 2023
| def find_or_build_default_price | ||
| default_price_or_build | ||
| end | ||
| deprecate :find_or_build_default_price, deprecator: Spree::Deprecation |
There was a problem hiding this comment.
We're trying to get better with yard documentation, so here we have a nice opportunity to use the @deprecated tag: https://rubydoc.info/gems/yard/file/docs/Tags.md#deprecated 🙂
This method was renamed to `default_price_or_build` with 6420b10, but this was a breaking change given it was released with Solidus 3.1. This commit reintroduces the method as an alias but with deprecation.
spaghetticode
force-pushed
the
add-back-variant-find_or_build_default_price
branch
from
ae37846 to
65a6f2d
Compare
|
@kennyadsl @waiting-for-dev thanks for the precious suggestions ❤️ |
waiting-for-dev
approved these changes
Mar 2, 2023
kennyadsl
approved these changes
Mar 2, 2023
This was referenced Mar 2, 2023
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
waiting-for-dev
added a commit
that referenced
this pull request
Mar 2, 2023
[v3.3] Merge pull request #4960 from spaghetticode/add-back-variant-find_or_build_default_price
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Mar 17, 2023
Please, use #default_price_or_build instead. Ref solidusio#4960
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Mar 21, 2023
Please, use #default_price_or_build instead. Ref solidusio#4960
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Apr 12, 2023
Please, use #default_price_or_build instead. Ref solidusio#4960
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Apr 14, 2023
Please, use #default_price_or_build instead. Ref solidusio#4960
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Apr 18, 2023
Please, use #default_price_or_build instead. Ref solidusio#4960
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Apr 24, 2023
Please, use #default_price_or_build instead. Ref solidusio#4960
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This method was renamed to
default_price_or_buildwith 6420b10, but this was a breaking change given it was released with Solidus 3.1. This commit reintroduces the method as an alias but with deprecation.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: