Allow to set order_update_attributes_class #4955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog:solidus_api
There was a problem hiding this comment.
Thanks, @tvdeyen. Left a suggestion to improve consistency.
|
@tvdeyen Hey Thomas, any chance to look at Marc's comment above? Let us know if we can help moving this forward, |
|
@kennyadsl sure, I can do that. Thanks for the reminder 😁 |
tvdeyen
force-pushed
the
make-OrderUpdateAttributes-configurable
branch
from
f3cbb4f to
e4a2b21
Compare
Codecov Report
@@ Coverage Diff @@
## master #4955 +/- ##
===========================================
- Coverage 85.88% 34.31% -51.57%
===========================================
Files 533 123 -410
Lines 13225 4292 -8933
===========================================
- Hits 11358 1473 -9885
- Misses 1867 2819 +952
... and 566 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@tvdeyen, rebasing from master should fix CI |
Allows providing your own order update attributes class for checkout.
tvdeyen
force-pushed
the
make-OrderUpdateAttributes-configurable
branch
from
e4a2b21 to
8ac56e9
Compare
kennyadsl
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows providing your own order update attributes class for checkout.
Some shops may have additional attributes on payments that needs to be store during
checkout. This allows to provide a class that responds to "apply" with the same signature as Spree::OrderUpdateAttributes
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: