Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky spec helper for local testing #4948

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Conversation

kennyadsl
Copy link
Member

Summary

Locally, it was not running flaky specs, because I forgot to add the normal run when we are not in the CI.

I noticed this by running specs locally and seeing that flaky were skipped.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

Locally, it was not running flaky specs, because I forgot
to add the normal run when we are not in the CI.

I noticed this by running specs locally and seeing that
flaky were skipped.
@kennyadsl kennyadsl requested review from elia and gsmendoza February 17, 2023 14:33
@kennyadsl kennyadsl requested a review from a team as a code owner February 17, 2023 14:33
@kennyadsl kennyadsl self-assigned this Feb 17, 2023
@kennyadsl kennyadsl added the type:bug Error, flaw or fault label Feb 17, 2023
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Feb 17, 2023
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #4948 (3ee9736) into master (7be1937) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4948      +/-   ##
==========================================
- Coverage   86.69%   86.69%   -0.01%     
==========================================
  Files         578      578              
  Lines       14673    14674       +1     
==========================================
  Hits        12721    12721              
- Misses       1952     1953       +1     
Impacted Files Coverage Δ
core/lib/spree/testing_support/flaky.rb 87.50% <0.00%> (-12.50%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kennyadsl kennyadsl merged commit 0d89c89 into master Feb 20, 2023
@kennyadsl kennyadsl deleted the kennyadsl/flaky-fix branch February 20, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem type:bug Error, flaw or fault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants