Fix CI only testing with the paperclip adapter #4905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since solidusio#4666, all jobs have been running with the paperclip adapter. The reason is that when the `paperclip` parameter was `false` on CircleCI, that translated into the `DISABLE_ACTIVE_STORAGE` env var being the string `"false"`. As we were checking for the mere presence of `DISABLE_ACTIVE_STORAGE`, it always evaluated to `true`. Fixes solidusio#4901
github-actions
bot
added
the
changelog:solidus_core
kennyadsl
approved these changes
Feb 6, 2023
waiting-for-dev
added
backport-v3.2
backport-v3.3
waiting-for-dev
deleted the
waiting-for-dev/fix_ci_only_testing_paperclip
branch
This was referenced Feb 7, 2023
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
waiting-for-dev
added a commit
that referenced
this pull request
Feb 7, 2023
[v3.3] Merge pull request #4905 from nebulab/waiting-for-dev/fix_ci_only_testing_paperclip
waiting-for-dev
added a commit
that referenced
this pull request
Feb 7, 2023
[v3.2] Merge pull request #4905 from nebulab/waiting-for-dev/fix_ci_only_testing_paperclip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since #4666, all jobs have been running with the paperclip adapter.
The reason is that when the
paperclipparameter wasfalseon CircleCI, that translated into theDISABLE_ACTIVE_STORAGEenv var being the string"false". As we were checking for the mere presence ofDISABLE_ACTIVE_STORAGE, it always evaluated totrue.Fixes #4901
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: