Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERB fixes for the backend (🐛+💅) #4891

Merged
merged 11 commits into from
Feb 1, 2023
Merged

ERB fixes for the backend (🐛+💅) #4891

merged 11 commits into from
Feb 1, 2023

Conversation

elia
Copy link
Member

@elia elia commented Jan 31, 2023

Summary

After randomly noticing a badly closed HTML tag I ran a couple of linters on the entire body of ERB files within backend/app/views. The two linters are erb-formatter and erb_lint.

I only used autocorrect sparingly and avoided reformatting everything, only some of the changes are straight up bugfixes, the most obvious exception being the extra newlines removed.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

  • I have written a thorough PR description.
  • I have kept my commits small and atomic.
  • I have used clear, explanatory commit messages.
  • I have documented new code with YARD.

The following are not always needed (cross them out if they are not):

  • I have added automated tests to cover my changes.
  • I have attached screenshots to demo visual changes.
  • I have opened a PR to update the guides.
  • I have updated the README to account for my changes.

@elia elia self-assigned this Jan 31, 2023
@github-actions github-actions bot added changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem labels Jan 31, 2023
@elia elia marked this pull request as ready for review January 31, 2023 18:29
@elia elia requested a review from a team as a code owner January 31, 2023 18:29
kennyadsl
kennyadsl approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Elia! I hope no deface override out there is targeting a wrong html/erb tag! 😁

@kennyadsl kennyadsl added the type:enhancement Proposed or newly added feature label Jan 31, 2023
waiting-for-dev
waiting-for-dev approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@waiting-for-dev waiting-for-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do we want to ignore some of those commits on git-blame? See #4741

@elia
Copy link
Member Author

elia commented Feb 1, 2023

@waiting-for-dev yes! I'll provide a PR once it's merged and the commit refs are stable 👍👍👍

@elia elia force-pushed the elia/admin-erb-fixes branch from 1b6d41d to 3e66a2a Compare February 1, 2023 11:50
@kennyadsl kennyadsl merged commit e9debb9 into solidusio:master Feb 1, 2023
@kennyadsl kennyadsl deleted the elia/admin-erb-fixes branch February 1, 2023 21:34
@kennyadsl kennyadsl mentioned this pull request Feb 1, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adammathys adammathys adammathys approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

@waiting-for-dev waiting-for-dev waiting-for-dev approved these changes

Assignees

@elia elia

Labels
changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem type:enhancement Proposed or newly added feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elia @waiting-for-dev @kennyadsl @adammathys