Update the SolidusFrontend dependency to 3.4.0.dev #4889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit aaa136f. Since we'll point solidus_frontend to 3.4.0.dev, we should be able to fetch the master version of solidus_frontend from GitHub.
github-actions
bot
added
changelog:solidus_core
waiting-for-dev
approved these changes
Jan 30, 2023
elia
approved these changes
Jan 30, 2023
| @@ -3,7 +3,10 @@ | |||
| if Bundler.locked_gems.dependencies['solidus_frontend'] | |||
| say_status :skipping, "solidus_frontend is already in the bundle", :blue | |||
| else | |||
| bundle_command("add solidus_frontend") | |||
| # `solidus_frontend` is not sourced from rubygems if the solidus gem was not. | |||
| github_solidus_frontend = '--github solidusio/solidus_frontend' unless solidus.nil? || solidus.source.is_a?(Bundler::Source::Rubygems) | |||
There was a problem hiding this comment.
nit: I think this can be reversed to if solidus && !solidus.source.is_a?(Bundler::Source::Rubygems)
There was a problem hiding this comment.
@elia I can submit a separate PR to make this refactoring. At the moment, I would just like to get this PR merged so that I can get the SolidusBraintree CI to pass...
waiting-for-dev
deleted the
gsmendoza/4878-set-solidus-frontend-to-3-4-0-dev
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4878.
Also reverts aaa136f. Since solidus_frontend 3.4.0.dev is released, we should be able to fetch the unreleased updates to 3.4.0.dev from GitHub.
Testing
The SolidusBraintree CI passes when pointing to this branch: https://app.circleci.com/pipelines/github/solidusio/solidus_braintree/218/workflows/09db5b6d-df33-4b27-9adb-9eaee4196163.
Here's the change to the SolidusBraintree Gemfile: solidusio/solidus_braintree@3e95898.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
[ ] I have documented new code with YARD.The following are not always needed (
cross them outif they are not):[ ] I have added automated tests to cover my changes.[ ] I have attached screenshots to demo visual changes.[ ] I have opened a PR to update the guides.[ ] I have updated the README to account for my changes.