Stop using RSpec is_expected with block expectations

[kennyadsl]

Summary

This syntax support is ending and it was printing a number of deprecation messages in our test suite output.

From One-line syntax documentation:

The one-liner syntax only works with non-block expectations
(e.g. expect(obj).to eq, etc) and it cannot be used with block
expectations (e.g. expect { object }).

List of related deprecation warnings removed

Deprecation Warnings:

The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to change `Spree::Address#state_name` from "A State Name" to nil` not `expect(value).to change `Spree::Address#state_name` from "A State Name" to nil`

The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to change `Spree::Address#state` from #<Spree::State id: 1311, name: "maryland", abbr: "md", country_id:...at: "2023-01-24 05:57:48.394225000 +0000", created_at: "2023-01-24 05:57:48.394225000 +0000"> to nil` not `expect(value).to change `Spree::Address#state` from #<Spree::State id: 1311, name: "maryland", abbr: "md", country_id:...at: "2023-01-24 05:57:48.394225000 +0000", created_at: "2023-01-24 05:57:48.394225000 +0000"> to nil`

The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to change `Spree::Address.count` by 1` not `expect(value).to change `Spree::Address.count` by 1`

The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to change `Spree::Order#last_ip_address` to "127.0.0.1"` not `expect(value).to change `Spree::Order#last_ip_address` to "127.0.0.1"`
The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to change `Spree::Order#last_ip_address` to "127.0.0.1"` not `expect(value).to change `Spree::Order#last_ip_address` to "127.0.0.1"`
The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to change `Spree::Order#last_ip_address` to "127.0.0.1"` not `expect(value).to change `Spree::Order#last_ip_address` to "127.0.0.1"`

The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to change `Spree::UserAddress.count` by 1` not `expect(value).to change `Spree::UserAddress.count` by 1`

The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to change `[address.state, address.state_name]` from [nil, "maryland"] to [#<Spree::State id: 1317, name..._at: "2023-01-24 05:57:48.428391000 +0000", created_at: "2023-01-24 05:57:48.428391000 +0000">, nil]` not `expect(value).to change `[address.state, address.state_name]` from [nil, "maryland"] to [#<Spree::State id: 1317, name..._at: "2023-01-24 05:57:48.428391000 +0000", created_at: "2023-01-24 05:57:48.428391000 +0000">, nil]`

The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to change `original_user_address.reload.default` from true` not `expect(value).to change `original_user_address.reload.default` from true`

The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to change `original_user_address.reload.default`` not `expect(value).to change `original_user_address.reload.default``

The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to change `original_user_bill_address.reload.default_billing` from true to false` not `expect(value).to change `original_user_bill_address.reload.default_billing` from true to false`

The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to change `original_user_bill_address.reload.default_billing`` not `expect(value).to change `original_user_bill_address.reload.default_billing``

The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to change `taxon2.reload.permalink` from "t/t2" to "t/foo"` not `expect(value).to change `taxon2.reload.permalink` from "t/t2" to "t/foo"`
The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to change `taxon2.reload.permalink` from "t/t2" to "t/foo"` not `expect(value).to change `taxon2.reload.permalink` from "t/t2" to "t/foo"`

The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to change `taxon2.reload.permalink` from "t/t2" to "t/special-characters"` not `expect(value).to change `taxon2.reload.permalink` from "t/t2" to "t/special-characters"`

The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to change `taxon2.reload.permalink` from "t/t2" to "t/t1/foo"` not `expect(value).to change `taxon2.reload.permalink` from "t/t2" to "t/t1/foo"`

The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to change `taxon2.reload.permalink` from "t/t2" to "t/t1/t2"` not `expect(value).to change `taxon2.reload.permalink` from "t/t2" to "t/t1/t2"`

The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to change `taxon2_child.reload.permalink` from "t/t2/t2_child" to "t/foo/t2_child"` not `expect(value).to change `taxon2_child.reload.permalink` from "t/t2/t2_child" to "t/foo/t2_child"`
The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to change `taxon2_child.reload.permalink` from "t/t2/t2_child" to "t/foo/t2_child"` not `expect(value).to change `taxon2_child.reload.permalink` from "t/t2/t2_child" to "t/foo/t2_child"`

The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to change `taxon2_child.reload.permalink` from "t/t2/t2_child" to "t/special-characters/t2_child"` not `expect(value).to change `taxon2_child.reload.permalink` from "t/t2/t2_child" to "t/special-characters/t2_child"`

The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to change `taxon2_child.reload.permalink` from "t/t2/t2_child" to "t/t1/foo/t2_child"` not `expect(value).to change `taxon2_child.reload.permalink` from "t/t2/t2_child" to "t/t1/foo/t2_child"`

The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to change `taxon2_child.reload.permalink` from "t/t2/t2_child" to "t/t1/t2/t2_child"` not `expect(value).to change `taxon2_child.reload.permalink` from "t/t2/t2_child" to "t/t1/t2/t2_child"`

The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to change `user.reload.addresses.count` by 1` not `expect(value).to change `user.reload.addresses.count` by 1`

The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to raise ActiveRecord::RecordInvalid` not `expect(value).to raise ActiveRecord::RecordInvalid`

The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to raise StateMachines::InvalidTransition with message matching /We are unable to calculate shipping rates for the selected items./` not `expect(value).to raise StateMachines::InvalidTransition with message matching /We are unable to calculate shipping rates for the selected items./`

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

• I have written a thorough PR description.
• I have kept my commits small and atomic.
• I have used clear, explanatory commit messages.

The following are not always needed (cross them out if they are not):

• I have added automated tests to cover my changes.
• I have attached screenshots to demo visual changes.
• I have opened a PR to update the guides.
• I have updated the README to account for my changes.